Open
Conversation
CTTY
reviewed
Jun 19, 2025
CTTY
reviewed
Jun 24, 2025
CTTY
reviewed
Jun 27, 2025
geruh
reviewed
Jul 2, 2025
geruh
reviewed
Jul 2, 2025
geruh
reviewed
Jul 3, 2025
geruh
reviewed
Jul 9, 2025
geruh
suggested changes
Jul 9, 2025
geruh
suggested changes
Jul 15, 2025
|
|
||
| return matching_files | ||
|
|
||
| def _can_contain_eq_deletes_for_file(self, data_file: DataFile, delete_wrapper: EqualityDeleteFileWrapper) -> bool: |
There was a problem hiding this comment.
Can you compare this to java implementaion again i see java uses contains null and all null with range check helpers.
Owner
Author
There was a problem hiding this comment.
I have added the same checks just doing them inline directly in _can_contain_eq_deletes_for_file(). Should I create helpers and call them in _can_contain_eq_deletes_for_file() ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equality Delete Support - 1
This PR implements equality delete support -1 for the Python Iceberg library.
Changes
-> Added functionality to match equality deletes to data files
-> Enhanced PyArrow IO implementation to handle equality delete files
-> Added some test cases to verify functions added for equality delete support
-> Added test fixtures for equality delete testing
Testing
All tests pass, including new tests for equality delete functionality.
Related Issues
This is part of the project to support equality deletes in the Python Iceberg implementation, aligning with the Iceberg spec.